Bump `lambda_http` dependency of `aws-smithy-http-server` to 0.8.0 #2685

david-perez · 2023-05-09T15:38:03Z

This patch also removes the unneeded dependency on lambda_runtime by
aws-smithy-http-server-python.

This patch also refactors LambdaHandler's convert_event to avoid
cloning the URI path when not needed.

This is a breaking change. See #2676 why.

This patch also bumps aws-smithy-http-server dependency on mime to 0.3.4.

cargo +nightly-2022-11-16 minimal-versions check --all-features otherwise
fails when using 0.3.0, because we require impl fmt::Display for mime::FromStrError, which was first introduced in 0.3.4.

As to why minimal-versions is now picking mime 0.3.0 with this patch, it's
because in lambda_http 0.7.3, they had mime = "0.3.16",
and in lambda_http 0.8.0, they've now relaxed that to mime = "0.3".

Checklist

I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This patch also removes the unneeded dependency on `lambda_runtime` by `aws-smithy-http-server-python`. This patch also refactors `LambdaHandler`'s `convert_event` to avoid cloning the URI path when not needed. This is a breaking change. See #2676 why.

github-actions · 2023-05-09T16:04:32Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

`cargo +nightly-2022-11-16 minimal-versions check --all-features` otherwise fails when using 0.3.0, because we require `impl fmt::Display for mime::FromStrError`, which was first introduced in 0.3.4.

david-perez · 2023-05-10T08:59:29Z

In CI, cargo +nightly-2022-11-16 minimal-versions check --all-features on aws-smithy-http-server fails with:

Checking mime v0.3.0
...
error[E0599]: the method `as_display` exists for reference `&FromStrError`, but its trait bounds were not satisfied
  --> aws-smithy-http-server/src/rejection.rs:18:13
   |
18 |     #[error("invalid `Content-Type` header value mime type: {0}")]
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method cannot be called on `&FromStrError` due to unsatisfied trait bounds
   |
  ::: /opt/cargo/registry/src/github.aaakk.us.kg-1ecc6299db9ec823/mime-0.3.0/src/lib.rs:72:1
   |
72 | pub struct FromStrError {
   | ----------------------- doesn't satisfy `FromStrError: std::fmt::Display`
   |
   = note: the following trait bounds were not satisfied:
           `FromStrError: std::fmt::Display`
           which is required by `&FromStrError: DisplayAsDisplay`

Indeed, we require mime::FromStrError: std::fmt::Display, but said trait was first implemented in this commit, which first made its way out in mime 0.3.4. As to why minimal-versions is now picking mime 0.3.0 with this patch, it's because in lambda_http 0.7.3, they had mime = "0.3.16", and in lambda_http 0.8.0, they've now relaxed that to mime = "0.3".

I'll go ahead and bump the dependency of aws-smithy-http-server on mime to 0.3.4 and update the PR description.

…-runtime-deps-to-0.8.0

github-actions · 2023-05-10T09:32:08Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK
No codegen difference in the Client Test
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

…0.8.0 (#2685)" This reverts commit 04db5e3. This is a breaking change that needs to wait to be merged in until the next breaking release.

…0.8.0 (#2685)" (#2690) This reverts commit 04db5e3. This is a breaking change that needs to wait to be merged in until the next breaking release. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

…2685) This patch also removes the unneeded dependency on `lambda_runtime` by `aws-smithy-http-server-python`. This patch also refactors `LambdaHandler`'s `convert_event` to avoid cloning the URI path when not needed. This is a breaking change. See #2676 why. This patch also bumps `aws-smithy-http-server` dependency on `mime` to 0.3.4. `cargo +nightly-2022-11-16 minimal-versions check --all-features` otherwise fails when using 0.3.0, because we require `impl fmt::Display for mime::FromStrError`, which was first introduced in 0.3.4. As to why `minimal-versions` is now picking `mime` 0.3.0 with this patch, it's because in `lambda_http` 0.7.3, they had [`mime = "0.3.16"`](https://github.com/awslabs/aws-lambda-rust-runtime/blob/99dba6447253ac87cf3cefeb2ba130b50514f9df/lambda-http/Cargo.toml#L35-L35), and in `lambda_http` 0.8.0, they've now relaxed that to [`mime = "0.3"`](https://github.com/awslabs/aws-lambda-rust-runtime/blob/393d6447bea0502e1f939d197f4facc228e6e007/lambda-http/Cargo.toml#L36). ## Checklist  - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

…0.8.0 (#2685)" (#2690) This reverts commit 04db5e3. This is a breaking change that needs to wait to be merged in until the next breaking release. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

…2685) This patch also removes the unneeded dependency on `lambda_runtime` by `aws-smithy-http-server-python`. This patch also refactors `LambdaHandler`'s `convert_event` to avoid cloning the URI path when not needed. This is a breaking change. See #2676 why. This patch also bumps `aws-smithy-http-server` dependency on `mime` to 0.3.4. `cargo +nightly-2022-11-16 minimal-versions check --all-features` otherwise fails when using 0.3.0, because we require `impl fmt::Display for mime::FromStrError`, which was first introduced in 0.3.4. As to why `minimal-versions` is now picking `mime` 0.3.0 with this patch, it's because in `lambda_http` 0.7.3, they had [`mime = "0.3.16"`](https://github.com/awslabs/aws-lambda-rust-runtime/blob/99dba6447253ac87cf3cefeb2ba130b50514f9df/lambda-http/Cargo.toml#L35-L35), and in `lambda_http` 0.8.0, they've now relaxed that to [`mime = "0.3"`](https://github.com/awslabs/aws-lambda-rust-runtime/blob/393d6447bea0502e1f939d197f4facc228e6e007/lambda-http/Cargo.toml#L36). ## Checklist  - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

…0.8.0 (#2685)" (#2690) This reverts commit 04db5e3. This is a breaking change that needs to wait to be merged in until the next breaking release. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

…2685) This patch also removes the unneeded dependency on `lambda_runtime` by `aws-smithy-http-server-python`. This patch also refactors `LambdaHandler`'s `convert_event` to avoid cloning the URI path when not needed. This is a breaking change. See #2676 why. This patch also bumps `aws-smithy-http-server` dependency on `mime` to 0.3.4. `cargo +nightly-2022-11-16 minimal-versions check --all-features` otherwise fails when using 0.3.0, because we require `impl fmt::Display for mime::FromStrError`, which was first introduced in 0.3.4. As to why `minimal-versions` is now picking `mime` 0.3.0 with this patch, it's because in `lambda_http` 0.7.3, they had [`mime = "0.3.16"`](https://github.com/awslabs/aws-lambda-rust-runtime/blob/99dba6447253ac87cf3cefeb2ba130b50514f9df/lambda-http/Cargo.toml#L35-L35), and in `lambda_http` 0.8.0, they've now relaxed that to [`mime = "0.3"`](https://github.com/awslabs/aws-lambda-rust-runtime/blob/393d6447bea0502e1f939d197f4facc228e6e007/lambda-http/Cargo.toml#L36). ## Checklist  - [x] I have updated `CHANGELOG.next.toml` if I made changes to the smithy-rs codegen or runtime crates ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

…0.8.0 (#2685)" (#2690) This reverts commit 04db5e3. This is a breaking change that needs to wait to be merged in until the next breaking release. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

…2685) (#2691) This is #2685 again, which was merged prematurely and reverted in #2690. This time we won't merge it until it's due time. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._

david-perez added next-release fixes / updates that need to be merged prior to release breaking-change This will require a breaking change server Rust server SDK labels May 9, 2023

david-perez requested review from a team as code owners May 9, 2023 15:38

david-perez requested a review from unexge May 9, 2023 15:38

jjant approved these changes May 9, 2023

View reviewed changes

Bump aws-smithy-http-server dependency on mime to 0.3.4

41ce262

`cargo +nightly-2022-11-16 minimal-versions check --all-features` otherwise fails when using 0.3.0, because we require `impl fmt::Display for mime::FromStrError`, which was first introduced in 0.3.4.

Merge remote-tracking branch 'upstream/main' into davidpz/bump-lambda…

9938ab8

…-runtime-deps-to-0.8.0

david-perez added this pull request to the merge queue May 10, 2023

Merged via the queue into main with commit 04db5e3 May 10, 2023

david-perez deleted the davidpz/bump-lambda-runtime-deps-to-0.8.0 branch May 10, 2023 10:06

david-perez added a commit that referenced this pull request May 10, 2023

Revert "Bump lambda_http dependency of aws-smithy-http-server to …

1ca30ca

…0.8.0 (#2685)" This reverts commit 04db5e3. This is a breaking change that needs to wait to be merged in until the next breaking release.

david-perez mentioned this pull request May 10, 2023

Bump lambda_http dependency of aws-smithy-http-server to 0.8.0 (#2685) #2691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump `lambda_http` dependency of `aws-smithy-http-server` to 0.8.0 #2685

Bump `lambda_http` dependency of `aws-smithy-http-server` to 0.8.0 #2685

david-perez commented May 9, 2023 •

edited

Loading

github-actions bot commented May 9, 2023

david-perez commented May 10, 2023

github-actions bot commented May 10, 2023

Bump lambda_http dependency of aws-smithy-http-server to 0.8.0 #2685

Bump lambda_http dependency of aws-smithy-http-server to 0.8.0 #2685

Conversation

david-perez commented May 9, 2023 • edited Loading

Checklist

github-actions bot commented May 9, 2023

david-perez commented May 10, 2023

github-actions bot commented May 10, 2023

Bump `lambda_http` dependency of `aws-smithy-http-server` to 0.8.0 #2685

Bump `lambda_http` dependency of `aws-smithy-http-server` to 0.8.0 #2685

david-perez commented May 9, 2023 •

edited

Loading